search

crossplane-contrib / provider-alibaba

Crossplane provider for Alibaba Cloud
Apache License 2.0
50 stars 18 forks source link

"make reviewable" hit "unsupported go version" issue #70

Open zzxwill opened 3 years ago

zzxwill commented 3 years ago

What happened?

When executing make reviewable, an issue happended.

➜  /Users/zhouzhengxi/Programming/golang/src/github.com/crossplane/provider-alibaba git:(master) make reviewable
13:41:56 [ .. ] go generate darwin_amd64
13:42:03 [ OK ] go generate darwin_amd64
13:42:03 [ .. ] cleaning generated CRDs
13:42:04 [ OK ] cleaned generated CRDs
13:42:04 [ .. ] verify dependencies have expected content
all modules verified
13:42:08 [ OK ] go modules dependencies verified
13:42:08 [FAIL] unsupported go version. Please make install one of the following supported version: 1.7|1.8|1.9|1.10|1.11|1.12|1.13|1.14
make[1]: *** [go.init] Error 1
make: *** [lint] Error 2

➜  /Users/zhouzhengxi/Programming/golang/src/github.com/crossplane/provider-alibaba git:(master) go version
go version go1.14.9 darwin/amd64

The go version meets 1.14.

How can we reproduce it?

What environment did it happen in?

Crossplane version: NA

muvaf commented 3 years ago

Bumping build submodule to latest should fix this, see https://github.com/upbound/build/pull/140 for details.

zzxwill commented 3 years ago

@muvaf I made a PR in #72, but test CI failed. It's successful in my local run. Could you please help retry the CI? Thanks.

muvaf commented 3 years ago

The error is related to this line. At some point, kind started not accepting capitals in cluster name so we changed INTTESTS to inttests in all providers.

zzxwill commented 3 years ago

@muvaf I have fixed most issues you figured out. Now it failed when make check-diff in PR #72. I could not figure out why without any more detailed information and it worked in my local development environment. Could you please help take a look at it?