crossplane-contrib / provider-argocd

Crossplane provider to provision and manage Argo CD objects
Apache License 2.0
68 stars 35 forks source link

feat: add grpc-web support #102 #103

Closed Avarei closed 10 months ago

Avarei commented 11 months ago

Description of your changes

Implements #102

Adds optional fields GRPCWeb and GRPCWebRootPath to providerconfig and hands them over to the argocd client library.

I have:

How has this code been tested

Created a cluster object in an argocd behind a proxy without gRPC support. Created another cluster object in an argocd within the same cluster over a k8s service (grpcWeb set to false).

I was not yet able to test GRPCWebRootPath

Avarei commented 10 months ago

I implemented your feedback and successfully ran make reviewable again. I did not test these changes against an argocd yet. I will do that on monday.

Avarei commented 10 months ago

For me everything is working as expected in my cluster and agains my argocd