Closed Avarei closed 10 months ago
I implemented your feedback and successfully ran make reviewable
again.
I did not test these changes against an argocd yet. I will do that on monday.
For me everything is working as expected in my cluster and agains my argocd
Description of your changes
Implements #102
Adds optional fields
GRPCWeb
andGRPCWebRootPath
to providerconfig and hands them over to the argocd client library.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Created a cluster object in an argocd behind a proxy without gRPC support. Created another cluster object in an argocd within the same cluster over a k8s service (grpcWeb set to false).
I was not yet able to test GRPCWebRootPath