search

crossplane-contrib / provider-argocd

Crossplane provider to provision and manage Argo CD objects
Apache License 2.0
68 stars 35 forks source link

update crossplane-runtime to v1.15.2 #110

Closed haarchri closed 4 months ago

haarchri commented 10 months ago

Description of your changes

Fixes #

I have:

How has this code been tested

MisterMX commented 9 months ago

This is currently not possible to compile because github.com/argoproj/argo-cd/v2 uses an older version of k8s.io/client-go that breaks with the one that is used in github.com/crossplane/crossplane-runtime.

haarchri commented 9 months ago

i know ;) thats why its a draft - but with this branch we can use provider-argocd in functions

maximilianbraun commented 8 months ago

I think if that will be merged, the crossplane-runtime update should work quite well. All the replace's in the mod-file could be removed… https://github.com/argoproj/gitops-engine/pull/556

github-actions[bot] commented 5 months ago

Crossplane does not currently have enough maintainers to address every issue and pull request. This pull request has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 7 days if no further activity occurs. closed in 7 days if no further activity occurs. Adding a comment starting with /fresh will mark this PR as not stale.

MisterMX commented 5 months ago

/fresh

MisterMX commented 4 months ago

I have made the code compile by replacing github.com/argoproj/gitops-engine with https://github.com/asaf-erlich/gitops-engine/commit/1c9f565e644fb51cc9afc96116fd788ff70390b8 which is the WIP in https://github.com/argoproj/gitops-engine/pull/565.

Since we are not using the gitops-engine itself and only use the API types I think it is safe to merge this.