fix(delete): recreate cluster when deleted via argocd-ui

crossplane-contrib / provider-argocd

Crossplane provider to provision and manage Argo CD objects

Apache License 2.0

68 stars 35 forks source link

fix(delete): recreate cluster when deleted via argocd-ui #118

Closed haarchri closed 9 months ago

haarchri commented 9 months ago

Description of your changes

this PR solves a problem where, upon a user's deletion of a cluster through argocd-ui, the provider would recreate the cluster instead of displaying a permission denied error.

Fixes #116

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

create cluster
remove cluster via argocd-ui
cluster auto recreate
delete cluster

janwillies commented 9 months ago

Thanks @haarchri! I think it would be cleaner to implement this via the newly added filtering to the cluster LIST endpoint. What do you think?

haarchri commented 9 months ago

I'd like to straightforwardly address the current implementation with this pull request. Iam open to modifying it to a List endpoint for a v0.6.0 release in a seperate PR?