crossplane-contrib / provider-argocd

Crossplane provider to provision and manage Argo CD objects
Apache License 2.0
68 stars 35 forks source link

feat: add Argo CD Application #67

Closed maximilianbraun closed 1 year ago

maximilianbraun commented 1 year ago

Description of your changes

I have:

How has this code been tested

Unit tests have been added to the controllers & manual integration tests.

janwillies commented 1 year ago

Thanks a lot @maximilianbraun for this massive contribution! We'll take a look soon

MisterMX commented 1 year ago

Thanks for your contribution @maximilianbraun! Can you take a lot a the remarks I have added?

maximilianbraun commented 1 year ago

Thanks for your contribution @maximilianbraun! Can you take a lot a the remarks I have added?

Sure thing. Let me have a look :)

maximilianbraun commented 1 year ago

@MisterMX your comments should be addressed. I added an .editorconfig so others don't fall in the LF pitfall.

Let me know when you spot something.

maximilianbraun commented 1 year ago

@MisterMX done. It just came with the caveat that I had to initialise the external-name within the test, since the initialisers don't run there.