Closed maximilianbraun closed 1 year ago
Thanks a lot @maximilianbraun for this massive contribution! We'll take a look soon
Thanks for your contribution @maximilianbraun! Can you take a lot a the remarks I have added?
Thanks for your contribution @maximilianbraun! Can you take a lot a the remarks I have added?
Sure thing. Let me have a look :)
@MisterMX your comments should be addressed.
I added an .editorconfig
so others don't fall in the LF pitfall.
Let me know when you spot something.
@MisterMX done. It just came with the caveat that I had to initialise the external-name within the test, since the initialisers don't run there.
Description of your changes
goverter
(used within Crossplane as well)mockgen
to be executed withgo generate ./...
golangci-lint
version, which contained a contained a couple fixes regarding resource usageI have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Unit tests have been added to the controllers & manual integration tests.