crossplane-contrib / provider-civo

Apache License 2.0
22 stars 22 forks source link

Scaling only is triggered by node pool size change #10

Closed AlexsJones closed 2 years ago

AlexsJones commented 2 years ago
    if len(desiredCivoCluster.Spec.Pools) != len(remoteCivoCluster.Pools) {

In order to fix the update mechanism to work for instance count changes within a node pool this needs modification.

AlexsJones commented 2 years ago

https://github.com/crossplane-contrib/provider-civo/pull/11

exocode commented 2 years ago

Also changing server size is not applied.

Eg.:

Changing from size: g3.k3s.xsmall to size: g3.k3s.medium doesn't do anything. The size change is also not picked up when rescaling...

So

count: 3
size: g3.k3s.xsmall

to

count: 1
size: g3.k3s.medium

does not take effect. It is only rescaling but keeps the node size the same (in the example above it stays on xsmall)

AlexsJones commented 2 years ago
Screenshot 2021-12-23 at 17 55 29

Changing the node type is not supported as part of the rescaling of a node pool

exocode commented 2 years ago

@AlexsJones so, I then have to add a new nodepool, give it a new name, with a bigger server and set the other(old one) to zero? or delete it completely? Thank you

AlexsJones commented 2 years ago

If you want to change the machine types in a node pool from

count: 3
size: g3.k3s.xsmall

to

count: 3
size: g3.k3s.medium

I would just remove the old pool and add the new one

DMajrekar commented 2 years ago

This has been resolved in https://github.com/crossplane-contrib/provider-civo/pull/17