crossplane-contrib / provider-civo

Apache License 2.0
22 stars 22 forks source link

Add CNI field to spec #15

Closed RealHarshThakur closed 2 years ago

RealHarshThakur commented 2 years ago

Signed-off-by: Harsh Thakur harsh@civo.com

Description of your changes

Fixes #

I have:

How has this code been tested

RealHarshThakur commented 2 years ago

I wasn't able to find the make recipes to run reviewable, test, or generate deep copy files, crds.

haardikdharma10 commented 2 years ago

LGTM 👍

RealHarshThakur commented 2 years ago

@hasheddan Can you please help us figure out why check-diff is failing? It passes for me locally but doesn't seem to pass on the CI

RealHarshThakur commented 2 years ago

@hasheddan It doesn't produce a diff locally and check-diff doesn't complain either

Screenshot 2022-01-20 at 10 11 33 PM
alejandrojnm commented 2 years ago

Look good, but the check-diff failed, any idea ??

andyjeffries commented 2 years ago

Upstream fails with the same thing according to @RealHarshThakur , so merging.