Closed RealHarshThakur closed 2 years ago
I wasn't able to find the make recipes to run reviewable, test, or generate deep copy files, crds.
LGTM 👍
@hasheddan Can you please help us figure out why check-diff is failing? It passes for me locally but doesn't seem to pass on the CI
@hasheddan It doesn't produce a diff locally and check-diff doesn't complain either
Look good, but the check-diff failed, any idea ??
Upstream fails with the same thing according to @RealHarshThakur , so merging.
Signed-off-by: Harsh Thakur harsh@civo.com
Description of your changes
Fixes #
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested