search

crossplane-contrib / provider-civo

Apache License 2.0
22 stars 22 forks source link

Added Object Store Support for Crossplane #32

Open satakshigarg opened 2 years ago

satakshigarg commented 2 years ago

Added the support for Object Store for Crossplane. [Internal/Controllers/objectstore.go is in progress, please ignore]

Signed-off-by: satakshigarg satakshi@civo.com

Description of your changes

Fixes #

I have:

How has this code been tested

RealHarshThakur commented 2 years ago

We need access key and secret access key stored in a secret. Similar to how we handle kubeconfig with clusters. I believe it is supposed to a field https://github.com/crossplane-contrib/provider-civo/blob/main/apis/civo/cluster/v1alpha1/types.go#L50

satakshigarg commented 2 years ago

https://github.com/crossplane-contrib/provider-civo/blob/main/apis/civo/cluster/v1alpha1/types.go#L50

@RealHarshThakur so shall I remove the access key from spec struct and just add a var to the secret struct to the spec that contains secret access key and access key ?

RealHarshThakur commented 2 years ago

We need access key in spec. Yes, add another field called ConnectionDetails similar to how we did in cluster spec

satakshigarg commented 2 years ago

Can we keep all directory & file names in a small case? (e.g /ObjectStore -> /objectstore)

LGTM

Sure, I'll update the same