search

crossplane-contrib / provider-confluent

Crossplane upjet provider for Confluent Cloud: https://registry.terraform.io/providers/confluentinc/confluent/latest/docs
Apache License 2.0
6 stars 7 forks source link

Add Kafka Credentials to ProviderConfig Secret #19

Closed dmvariphy closed 3 months ago

dmvariphy commented 3 months ago

This branch adds kafkaAPIKey, kafkaAPISecret, and kafkaRESTEndpoint to the ProviderConfig secret. This resolves #18, which affected import of resources after provider-confluent restarted. See Terraform confluent provider docs for more info about this:

Fixes #18

I have:

How has this code been tested

Successfully ran e2e test with a kafkaacl resource against a Confluent Cloud basic cluster. Built and deployed the changes in this branch to two control planes and verified previously out of sync kafkaacl resources are successfully re-synced.

jaylevin commented 3 months ago

Thank you for the contribution @dmvariphy! It looks good to me 🚀

One small suggestion I have is to document both provider authentication options in the example providerconfig secret, similar to how the provider's terraform docs have done it.

dmvariphy commented 3 months ago

Hey @jaylevin -

I added the providerconfig secret like you mentioned (d836b9d), and if you'd like me to add the kafka_id/KafkaID field like we discussed in your above comment, just let me know!