search

crossplane-contrib / provider-digitalocean

Crossplane DigitalOcean infrastructure provider
https://crossplane.io/
Apache License 2.0
41 stars 26 forks source link

Move the load balancer out of `loadbalancer` group and into a `network` group #39

Open ADustyOldMuffin opened 2 years ago

ADustyOldMuffin commented 2 years ago

Somewhat breaking change we need to document well.

Here inside of the loadbalancer API definition https://github.com/crossplane-contrib/provider-digitalocean/blob/ee34f5c52423efcfc78791f7afb594e1cf8c6b0a/apis/loadbalancer/v1alpha1/doc.go#L17-L22

We should update the groupName to be network instead as well as rename the folder the file is in. This is because we're going to group the resources by their type and load balancer would fall into the inside the purview of networking stuff.

amoghrajesh commented 1 year ago

@ADustyOldMuffin I would like to work on this for Hacktoberfest. Could you provide a clear list of what is needed and assign the issue to me?

ADustyOldMuffin commented 1 year ago

Sure thing! The main thing is what was mentioned above, the groupName=loadbalancer.do.crossplane.io doesn't match other packages such as this one here.

The loadbalancer is apart of the Networking group of products and as such should be in that grouping, so that'd involve updating import references, the doc.go for it, and moving it's folder location. If you need any other information please let me know.

amoghrajesh commented 1 year ago

@ADustyOldMuffin I understand that the references do not match but what does grouping under a networking group mean? Can you share one reference where it grouped as?

ADustyOldMuffin commented 1 year ago

https://github.com/crossplane-contrib/provider-digitalocean/blob/a4257b6ec13aa66adca063b4fef11d9c31590417/examples/loadbalancer/loadbalancer.yaml#L1

It affects this field in the CRD.