crossplane-contrib / provider-equinix-metal

DEPRECATED: Use provider-jet-equinix :warning:
https://github.com/crossplane-contrib/provider-jet-equinix
Apache License 2.0
16 stars 8 forks source link

Update to be compatible with the v0.13 Crossplane release #30

Closed hasheddan closed 3 years ago

hasheddan commented 3 years ago

Description of your changes

Makes a variety of updates, including:

Fixes #27

Tested installation with Crossplane v0.13.0 using image built as hasheddan/crossplane-provider-equinix-metal.

Checklist

I have:

displague commented 3 years ago

I'm going to guess this is a docker build problem based on local configuration.. (Docker version 19.03.13, build 4484c46d9d)

$ make 
22:40:58 [ .. ] verify dependencies have expected content
all modules verified
22:41:02 [ OK ] go modules dependencies verified
22:41:02 [ .. ] golangci-lint
22:41:04 [ OK ] golangci-lint
22:41:05 [ .. ] go build linux_amd64
22:41:06 [ OK ] go build linux_amd64
22:41:08 [ .. ] docker build build-c57adf82/crossplane-provider-equinix-metal-amd64
quiet currently not implemented
22:41:09 [FAIL]
make[7]: *** [img.build] Error 1
make[6]: *** [do.build.artifacts.linux_amd64] Error 2
make[5]: *** [build.all] Error 2
make[4]: *** [build] Error 2
make[3]: *** [do.build.image.crossplane-provider-equinix-metal] Error 2
make[2]: *** [do.build.artifacts.linux_amd64] Error 2
make[1]: *** [build.all] Error 2
make: *** [build] Error 2

I don't see quiet anywhere, but there is a -q in build/.

displague commented 3 years ago

It builds after running docker buildx uninstall

hasheddan commented 3 years ago

@displague just wondering, if you run with DOCKER_BUILDKIT=1, does it build even with buildx installed? Also, does this PR look good to you? Looks like I can merge, but was waiting for explicit approval 🙂

displague commented 3 years ago

@hasheddan with DOCKER_BUILDKIT=1 it still fails.

$ docker buildx install
$ export DOCKER_BUILDKIT=1
$ make
09:31:09 [ .. ] verify dependencies have expected content
all modules verified
09:31:14 [ OK ] go modules dependencies verified
09:31:14 [ .. ] golangci-lint
09:31:17 [ OK ] golangci-lint
09:31:18 [ .. ] go build linux_amd64
09:31:18 [ OK ] go build linux_amd64
09:31:21 [ .. ] docker build build-c57adf82/crossplane-provider-equinix-metal-amd64
quiet currently not implemented
09:31:22 [FAIL]
make[7]: *** [img.build] Error 1
make[6]: *** [do.build.artifacts.linux_amd64] Error 2
make[5]: *** [build.all] Error 2
make[4]: *** [build] Error 2
make[3]: *** [do.build.image.crossplane-provider-equinix-metal] Error 2
make[2]: *** [do.build.artifacts.linux_amd64] Error 2
make[1]: *** [build.all] Error 2
make: *** [build] Error 2