require spec in managed types

crossplane-contrib / provider-equinix-metal

DEPRECATED: Use provider-jet-equinix :warning:

https://github.com/crossplane-contrib/provider-jet-equinix

Apache License 2.0

16 stars 8 forks source link

require spec in managed types #66

Closed displague closed 3 years ago

displague commented 3 years ago

Description of your changes

https://github.com/cncf/crossplane-conformance/pull/22#pullrequestreview-684673410

The spec field is required in managed types by the Crossplane Provider Conformance tests.

This change updates the provider to match that expectation.

Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[x] Updated any relevant documentation, examples, or release notes.

displague commented 3 years ago

Is there any chance folks were somehow using these resources successfully without a spec? Usually I find the answer to this is "no" because the resources in question aren't functional without some field or the other under spec.forProvider.

Thanks. In this case each of the resource types requires at least one piece of the spec to be meaningful.

The Crossplane documentation on importing existing resources says that both the external-name and any required spec fields must be provided to import the resource, so I assume this change is safe even for import use-cases.