Beta mgmt policy - Githubissues

crossplane-contrib / provider-gitlab

Crossplane Gitlab provider

Apache License 2.0

54 stars 26 forks source link

Beta mgmt policy #137

Closed jwhitcraft closed 2 months ago

jwhitcraft commented 2 months ago

Description of your changes

This enabled the using the Beta Management Policy Feature Flag

Fixes #136

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Built and tested in our test controlplane

MisterMX commented 2 months ago

The provider uses https://github.com/crossplane/crossplane-runtime v1.14.x which is using the alpha feature flag. As long as we don't make the upgrade to v1.15 this change wont work.

jwhitcraft commented 2 months ago

The provider uses https://github.com/crossplane/crossplane-runtime v1.14.x which is using the alpha feature flag. As long as we don't make the upgrade to v1.15 this change wont work.

From the looks of it, the feature went beta in 1.14.0rc1: https://github.com/crossplane/crossplane-runtime/commit/55a8c109304f3a03509216fb366230d965236c40

MisterMX commented 2 months ago

Closing this, since the underlying issue #136 is solved.