search

crossplane-contrib / provider-gitlab

Crossplane Gitlab provider
Apache License 2.0
54 stars 26 forks source link

feat: SamlGroupLinks #144

Closed jholt96 closed 1 month ago

jholt96 commented 2 months ago

Description of your changes

This PR adds SamlGroupLink functionality. This allows users to tie Saml groups to Gitlab groups using the samlGroupSync feature for Gitlab EE.

https://docs.gitlab.com/ee/user/group/saml_sso/group_sync.html

I have:

How has this code been tested

  1. Unit tests have been created to test the controller functionality for observe, connect, create, delete
  2. Tested in RKE2 cluster. I was able to create and delete saml group sync's on various groups.
jholt96 commented 1 month ago

Resolved previous lint Issues and ran the golangci-lint local with no errors

MisterMX commented 1 month ago

@jholt96 I think there is still an issue with the linter. Can you check again?

jholt96 commented 1 month ago

@jholt96 I think there is still an issue with the linter. Can you check again?

Just added the comment that the job was complaining about. Sorry about that. I figured running the tool locally would be the same output.