crossplane-contrib / provider-helm

Crossplane Helm Provider
Apache License 2.0
111 stars 65 forks source link

Configurable MaxConcurrentReconciles with a better default for max-reconcile-rate #211

Closed turkenh closed 9 months ago

turkenh commented 9 months ago

Description of your changes

This PR:

I have:

How has this code been tested

See https://github.com/crossplane-contrib/provider-kubernetes/pull/203

lsviben commented 9 months ago

Looks ok but not sure why the e2e test is failing. Is it broken? Ill try to debug locally, but I see same thing is happening on master

turkenh commented 9 months ago

Looks ok but not sure why the e2e test is failing. Is it broken? Ill try to debug locally, but I see same thing is happening on master

@lsviben my other PR could be fixing it: https://github.com/crossplane-contrib/provider-helm/pull/197/commits/27b35cc5bbeece71c3c261de1e41d6e0e95591b9

Working on making it up to date as you suggested, then we can rebase this one.