Fix linter errors - Githubissues

crossplane-contrib / provider-jet-aws

AWS Provider for Crossplane that is built with Terrajet.

https://crossplane.io

Apache License 2.0

37 stars 30 forks source link

Fix linter errors #107

Closed turkenh closed 2 years ago

turkenh commented 2 years ago

Description of your changes

Tiny fix resolving linter error.

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

make reviewable

turkenh commented 2 years ago

I had to increase the linter timeout 2mins to 10mins since it was taking too long. But it looks like it took much less after a successful run probably due to some sort of caching.

ulucinar commented 2 years ago

I think we will need to investigate/work on this linter issue. Why does it take too long / why when we retry it takes less time / does it store its progress between runs, etc.

turkenh commented 2 years ago

I think we will need to investigate/work on this linter issue. Why does it take too long / why when we retry it takes less time / does it store its progress between runs, etc.

Yeah definitely agree, opened this issue with some details to follow up on that. At this moment, I don't think it is urgent/critical.