Open ulucinar opened 2 years ago
I have couple of comments but it's quite hard to know whether they are doable or not without seeing the approach taken, which your planned one pager should help with.
Can we comment out the whole YAML in cases where it definitely won't work, for example the ones that contain any
${...}
section? Commenting out the whole YAML for every example that hasn't been tested could also be a good option, as described here.
Thanks @muvaf for the comments. We now generate the example manifests with all lines commented out as suggested. They can selectively be uncommented/edited when adjusting the example manifests.
@muvaf did you find time to review this? Thank you!
Description of your changes
In the context of: https://github.com/crossplane-contrib/terrajet/issues/48
Adds generated example manifests for the Terraform resources.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
An example generated manifest:
Corresponding Terraform registry example: