Closed sergenyalcin closed 2 years ago
@sergenyalcin Is there anything blocking this? It seems fine to merge after resolving the conflicts.
@sergenyalcin Is there anything blocking this? It seems fine to merge after resolving the conflicts.
Conflicts were resolved!
Description of your changes
Depends on https://github.com/crossplane/terrajet/issues/100
This PR depends on the following one -> https://github.com/crossplane/terrajet/pull/197 Until merge the dependent PR, a temporary replace command was added to go.mod:
https://github.com/sergenyalcin/provider-jet-aws/blob/ae8fb3a002c0e24f868d0d608fa365ef42d6da7e/go.mod#L26
This PR marks the passwords field of aws_elasticache_user as sensitive. Now, this field is not sensitive and the passwords are put to the spec directly. Because for []string and []*string types, there is not support as sensitive fields. The dependent PR will provide this support. After merging the dependent PR in terrajet, this PR can be merged.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Generation of the resource was successfully completed. The
PasswordsSecretRef
field was generated as*[]v1.SecretKeySelector
I created the following manifest: