search

crossplane-contrib / provider-jet-aws

AWS Provider for Crossplane that is built with Terrajet.
https://crossplane.io
Apache License 2.0
37 stars 30 forks source link

README Addition #163

Open natereid72 opened 2 years ago

natereid72 commented 2 years ago

Can we add requirement for Kubernetes API server version =>v1.23 to the README?

jbw976 commented 2 years ago

Feel free to open a PR with this contribution @natereid72, along with the explanation/details for why that version is needed :)

natereid72 commented 2 years ago

I'll close that PR and open a new one tomorrow. Need to switch laptops to sign.

natereid72 commented 2 years ago

idk, @jbw976 we may need to sync tomorrow on this. I signed it but DCO still showing issue with not signed,

bobh66 commented 2 years ago

Since this is an AWS provider, I assume a lot of people (like me) will be running it on EKS, which only supports up to Kubernetes 1.21. I think a recommendation of 1.23 would be fine, with an explanation of what the issue(s) are with earlier versions.

natereid72 commented 2 years ago

ok, replaced previous PR with #167. Git amend didn't seem to fix the sign-off issue in previous PR. Added statement on requirement and brief reason.