crossplane-contrib / provider-jet-aws

AWS Provider for Crossplane that is built with Terrajet.
https://crossplane.io
Apache License 2.0
37 stars 30 forks source link

Fix external name configuration for ECS Service #173

Closed turkenh closed 2 years ago

turkenh commented 2 years ago

Description of your changes

This PR fixes ECS Service external name configuration and adds a working/tested example.

Fixes #170

I have:

How has this code been tested

Using the (renamed) example manifest which is also added in this PR.

kubectl get -f examples/ecs/service.yaml -w
NAME                      READY   SYNCED   EXTERNAL-NAME             AGE
sample-service-by-hasan                    sample-service-by-hasan   2s
sample-service-by-hasan                    sample-service-by-hasan   35s
sample-service-by-hasan                    sample-service-by-hasan   35s
sample-service-by-hasan                    sample-service-by-hasan   35s
sample-service-by-hasan   False   True     sample-service-by-hasan   35s
sample-service-by-hasan   False   True     sample-service-by-hasan   35s
sample-service-by-hasan   False   True     sample-service-by-hasan   59s
sample-service-by-hasan   False   True     sample-service-by-hasan   63s
sample-service-by-hasan   False   True     sample-service-by-hasan   63s
sample-service-by-hasan   True    True     sample-service-by-hasan   77s
sample-service-by-hasan   True    True     sample-service-by-hasan   111s
github-actions[bot] commented 2 years ago

Successfully created backport PR #175 for release-0.4.