crossplane-contrib / provider-jet-aws

AWS Provider for Crossplane that is built with Terrajet.
https://crossplane.io
Apache License 2.0
37 stars 30 forks source link

Service Catalog resources in main provider-jet-aws release #177

Open mleahu opened 2 years ago

mleahu commented 2 years ago

What resource do you need?

AWS Service Catalog resources are already present in v0.4.0-preview and I successfully tested the product provisioning with CRD https://doc.crds.dev/github.com/crossplane-contrib/provider-jet-aws/servicecatalog.aws.jet.crossplane.io/ProvisionedProduct/v1alpha1@v0.4.0-preview However, there are other bugs in v0.4.0-preview, so this provider version is not usable.

Can the group of CRDs servicecatalog.aws.jet.crossplane.io be pulled into the main version of provider-jet-aws? That would be really great!

What is your use case?

I need to manage products via the AWS Service Catalog and I did not find CRDs in provider-aws to do that. The alternative is to use the freshly provider-jet-aws, but, as detailed above, the Service Catalog CRDs are usable only on a preview version of provider-jet-aws (v0.4.0-preview) which is very large and not maintained as it looks.

Thank you! That would help a lot!

mleahu commented 2 years ago

For the moment I generated a provider with only a few resources needed to provision an AWS service catalog product: https://github.com/mleahu/provider-jet-awssc

haarchri commented 2 years ago

Can you open a PR here ? Then we can bring it in

empath-nirvana commented 2 years ago

This actually will not work because provisioned product is not idempotent without providing a provisioning token, which is something that the provider generates randomly and is saved in the terraform state