feat(ec2-sg-sgr): added examples for securitygroup/rule ingress/egress

crossplane-contrib / provider-jet-aws

AWS Provider for Crossplane that is built with Terrajet.

https://crossplane.io

Apache License 2.0

37 stars 30 forks source link

feat(ec2-sg-sgr): added examples for securitygroup/rule ingress/egress #198

Closed haarchri closed 2 years ago

haarchri commented 2 years ago

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

added example for securitygroup
added example for securitygrouprule ingress & egress
skip in lateInit ingress and egress to make securitygroup standalone and add rules via securitygrouprule resource

Fixes #157

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

NAME                                                READY   SYNCED   EXTERNAL-NAME          AGE
securitygroup.ec2.aws.jet.crossplane.io/sample-sg   True    True     sg-0eff671498dc249cf   3m50s

NAME                                                            READY   SYNCED   EXTERNAL-NAME       AGE
securitygrouprule.ec2.aws.jet.crossplane.io/sample-egress-sgr   True    True     sgrule-358272172    2m33s
securitygrouprule.ec2.aws.jet.crossplane.io/sample-sgr          True    True     sgrule-3252498669   2m33s

ingress:

egress:

Striar-Yunis commented 2 years ago

Is there any update on reviewing haarchri's pull requests? They un-break several broken resources.

BGrasnick commented 2 years ago

Any progress on this? We also try using SecurityGroup and SecurityGroupRule together and get the same bug as in #157

haarchri commented 2 years ago

i will update shortly the PR

haarchri commented 2 years ago

updated the pr and removed ingress / egress from spec - because fields not needed because we have SecurityGroupRule Resource

haarchri commented 2 years ago

NAME                                                            READY   SYNCED   EXTERNAL-NAME       AGE
securitygrouprule.ec2.aws.jet.crossplane.io/sample-egress-sgr   True    True     sgrule-2184305446   4m27s
securitygrouprule.ec2.aws.jet.crossplane.io/sample-sgr          True    True     sgrule-4026632647   4m27s

NAME                                                READY   SYNCED   EXTERNAL-NAME          AGE
securitygroup.ec2.aws.jet.crossplane.io/sample-sg   True    True     sg-0be6bc2861968b8b1   5m31s

BGrasnick commented 2 years ago

Any chance to get this reviewed and hopefully approved and merged @muvaf? :)

haarchri commented 2 years ago

added a preview image from master(https://github.com/crossplane-contrib/provider-jet-aws/commit/4828ea6e33810604435d1b13de4f31138034e670) + https://github.com/crossplane-contrib/provider-jet-aws/pull/198 + https://github.com/crossplane-contrib/provider-jet-aws/pull/211 +https://github.com/crossplane-contrib/provider-jet-aws/pull/208 available under: haarchri/provider-jet-aws:v0.5.0-preview