crossplane-contrib / provider-jet-aws

AWS Provider for Crossplane that is built with Terrajet.
https://crossplane.io
Apache License 2.0
37 stars 30 forks source link

feat(ec2-tag): added ec2-tag resource #208

Closed haarchri closed 1 year ago

haarchri commented 2 years ago

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

added aws-ec2-tag resource

This tag resource should only be used in cases where EC2 resources are created outside Crossplane (e.g., AMIs), being shared via Resource Access Manager (RAM), or implicitly created by other means (e.g., EKS ClusterSecurityGroup, Transit Gateway VPN Attachments).

Fixes #

I have:

How has this code been tested

kubectl apply -f examples/ec2/tag.yaml

NAME                                    READY   SYNCED   EXTERNAL-NAME                                 AGE
tag.ec2.aws.jet.crossplane.io/example   True    True     sg-07ce66bf8dda6874b,karpenter.sh/discovery   87s
image

kubectl delete -f examples/ec2/tag.yaml tag is deleted

image
haarchri commented 2 years ago

added a preview image from master(https://github.com/crossplane-contrib/provider-jet-aws/commit/4828ea6e33810604435d1b13de4f31138034e670) + https://github.com/crossplane-contrib/provider-jet-aws/pull/198 + https://github.com/crossplane-contrib/provider-jet-aws/pull/211 +https://github.com/crossplane-contrib/provider-jet-aws/pull/208 available under: haarchri/provider-jet-aws:v0.5.0-preview

BGrasnick commented 2 years ago

This would be super helpful and necessary for our use cases as well... What are the chances this gets included in the next release? Is there anything we can do to support getting this feature into the next release?

BGrasnick commented 2 years ago

Is it possible to get this reviewed and merged for the next release @muvaf? Would be so helpful as we depend on it.

haarchri commented 1 year ago

i will close this PR