crossplane-contrib / provider-jet-aws

AWS Provider for Crossplane that is built with Terrajet.
https://crossplane.io
Apache License 2.0
37 stars 30 forks source link

feat(4.22.0): bumped to aws provider 4.22.0 and added grafana, amp #214

Closed haarchri closed 1 year ago

haarchri commented 2 years ago

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

breaking changed because of provider bump:

haarchri commented 2 years ago

@muvaf @jbw976 regarding api group version for new resources like grafana, amp/prometheus ? did we use v1alpha1 or v1alpha2 ?

haarchri commented 2 years ago

currently checking why observed is failing locally with make run for existing resources with:

.657479674736587e+09 DEBUG events Warning {"object": {"kind":"LBTargetGroup","name":"sample-lambda-targetgroup","uid":"34dee55d-e325-4b74-ae36-62ba5a45d01f","apiVersion":"elbv2.aws.jet.crossplane.io/v1alpha2","resourceVersion":"282025"}, "reason": "CannotObserveExternalResource", "message": "cannot run refresh: refresh failed: Provider requirements cannot be satisfied by locked dependencies: The following required providers are not installed:\n\n- registry.terraform.io/hashicorp/aws (4.22.0)\n\nPlease run \"terraform init\"."}

jbw976 commented 2 years ago

@haarchri I believe new resources, that are configured with external name, late init, cross resource references, etc. have been introduced at v1alpha2 in the past :)

ytsarev commented 2 years ago

@haarchri maybe it is a local invocation artifact. What will happen if you clean up the temporary terraform workspace directory?

haarchri commented 2 years ago

It's the same - i cleaned up because otherwise the make generate is not working with new version

ytsarev commented 2 years ago

We may be talking about different directories, I mean something like /var/folders/sx/$uuid/T/$another_uuid/ on macos or similar temp dir on linux.

They contain

main.tf.json
terraform.tfstate
terraform.tfstate.backup

of specific MR and definitely should not affect any code generation

haarchri commented 2 years ago

@ytsarev yeah - thanks for the hint

/var/folders/cz/2y38s5w127n7vc997qmxcsnr0000gn/T/a986a902-20ff-433a-b8cb-6b12c97a9208 removed the folder now it looks better