crossplane-contrib / provider-jet-aws

AWS Provider for Crossplane that is built with Terrajet.
https://crossplane.io
Apache License 2.0
37 stars 30 forks source link

Add associate_public_ip_address, vpc_security_group_ids, ipv6_address… #228

Open RealFatCat opened 2 years ago

RealFatCat commented 2 years ago

…es, ipv6_address_count to aws_instance ignored fields for proper work with attached network interface.

Signed-off-by: Oleg Senin olegsenin@yandex-team.ru

Description of your changes

Fix conflicts, when instance creates with network interface reference. Example:

apiVersion: ec2.aws.jet.crossplane.io/v1alpha2
kind: Instance
metadata:
  name: instance-a
spec:
  forProvider:
    region: us-east-2
    ami: ami-0b332808c98813fef
    instanceType: c5.xlarge
    keyName: key
    networkInterface:
    - deviceIndex: 0
      networkInterfaceIdRef:
        name: ni-a
  deletionPolicy: Delete
  providerConfigRef:
    name: default

I am not quite sure, that this is good idea to just ignore this fields, but it seems like there is no other solution right now.

I have:

How has this code been tested

Manual tests on aws.