Closed ytsarev closed 2 years ago
@ulucinar thanks a ton for the careful review, I've address two points in latest commit of https://github.com/crossplane-contrib/provider-jet-azure/pull/182/commits/641e3dec7171640957e5922f54ccbd0b8a33a78d, please check it up.
Let's align on https://github.com/crossplane-contrib/provider-jet-azure/pull/182#discussion_r868948937 , I do not have strong opinion against switching to NameAsIdentifier
but the UX is not something obvious to me here
Description of your changes
This PR configures, stabilizes and promotes to
v1alpha2
all existing mariadb resources, specificallyFixes #180
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
All provided examples were tested end-to-end with minimal naming modifications.
One caveat: I was not able to fully test
virtualnetworkrules.dbformariadb.azure.jet.crossplane.io
because it is not available on theBasic
azure plan I am using at the moment.Still, the Azure API has properly accepted the object and it should work properly.