search

crossplane-contrib / provider-jet-azure

Apache License 2.0
17 stars 20 forks source link

Remove groups from the CRD kind names #71

Open muvaf opened 2 years ago

muvaf commented 2 years ago

What problem are you facing?

The kind names are constructed by removing the Azurerm prefix. However that results in duplication of the group name in kind name, i.e. SqlServer in sql.azure.tf.crossplane.io or VirtualNetwork in virtual.azure.tf.crossplane.io

How could Crossplane help solve your problem?

In AWS, we opted for removing the group names from the kind calculation, for example instead of Ec2Vpc in ec2.aws.tf.crossplane.io, we have Vpc in ec2.aws.tf.crossplane.io. We can do the same thing here as well.

In case of duplications, users would be able to quantify using the initial part of the group name, i.e. kubectl get server.sql or kubectl get server.postgresql. That way it's closer to how they are represented in the cloud API.

muvaf commented 2 years ago

@ulucinar what are your thoughts on this? I think we'll need manual override in some cases, like aws_db_instance should actually be in rds group and there will be a way I believe to do those in an elegant way with https://github.com/crossplane-contrib/terrajet/issues/61 . But it'd be good to decide on the approach and rename the CRDs as soon as possible to avoid breaking user tests.