Closed Lax77 closed 2 years ago
Thanks a lot for the contribution. Could you please rebase with main after we merged #9 ?
Sure, just rebased the branch. Could you review it again?
@Lax77 thanks a lot! Did you also regenerate with make reviewable
? I might be wrong, but I am expecting the new Downtime CRD to be also involved in the diff
@ytsarev No, I only rebased earlier. Re-ran the make reviewable
and pushed the changes again.
This time it updated the downtime CRD with v3.12.0 specific changes. Along with CRD, apis in downtime/v1alpha1 were also updated.
Signed-off-by: Lax Kota lkota@guidewire.com Signed-off-by: Nimish Pawar npawar@guidewire.com
Description of your changes
Fixes # https://github.com/crossplane-contrib/provider-jet-datadog/issues/10
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
We have tested following [this] document were able to create and delete synthetic tests fine with these changes.