feat(dashboard): Add functionality to create Datadog dashboards

crossplane-contrib / provider-jet-datadog

@crossplane provider to drive @datadog configuration control plane way

Apache License 2.0

6 stars 8 forks source link

feat(dashboard): Add functionality to create Datadog dashboards #13

Closed nimish22 closed 2 years ago

nimish22 commented 2 years ago

Signed-off-by: Nimish Pawar npawar@guidewire.com

Description of your changes

Added the Datadog Dashboard resource to provider-jet-datadog

Fixes # https://github.com/crossplane-contrib/provider-jet-datadog/issues/12

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

We do have a manifest in examples/dashboard folder. We tested creating/deleting Datadog dashboard using this manifest.

ytsarev commented 2 years ago

Looks like it conflicted after the recent merge, could you please rebase with the branch? Thanks!

Kerwood commented 2 years ago

@nimish22 I'm having some trouble installing the dashboard CRD.

k apply -f https://raw.githubusercontent.com/crossplane-contrib/provider-jet-datadog/main/package/crds/dashboard.datadog.jet.crossplane.io_dashboards.yaml
The CustomResourceDefinition "dashboards.dashboard.datadog.jet.crossplane.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

Could it be because there's 25.422 lines in that CRD ?

Edit It was and apparently using kubectl create ... instead of apply will fix it for you :)