search

crossplane-contrib / provider-keycloak

Apache License 2.0
25 stars 16 forks source link

OIDCIdentityProvider Secret in InitProvider is required but should be optional #113

Open denniskniep opened 5 months ago

denniskniep commented 5 months ago

The Property IdentityProviderSpec.InitProvider.ClientSecretSecretRef (see https://github.com/crossplane-contrib/provider-keycloak/blame/11f3432fc6cbf1f12168f6e3ba425f79ad0d5710/apis/oidc/v1alpha1/zz_identityprovider_types.go#L55-L57)

is a required field since updating upjet to to v1.4.0 (see https://github.com/crossplane/upjet/releases/tag/v1.4.0 -> Support for Secret References in spec.initProvider)

InitProvider properties are set if the value of the property should only be taken into account during creation and not during update (see https://docs.crossplane.io/latest/concepts/managed-resources/#initprovider)

But from Keycloaks point of view the client secret of an OIDC IdentityProvider is NOT immutable.

Do we need to raise that issue to upjet, so that secret refs are generated as optional property?

Breee commented 5 months ago

Probably an upjet issue, maybe @haarchri can help to verify that.

Can you provide a minimal example ?