Closed ezgidemirel closed 1 month ago
Thanks @ezgidemirel ! LGTM, just have one question. Do we want to add a flag to enable/disable the metrics? How was this handled for other providers?
Thanks @ezgidemirel ! LGTM, just have one question. Do we want to add a flag to enable/disable the metrics? How was this handled for other providers?
Thanks @lsviben for your review! Here is an example PR from provider-upjet-aws. We don't have any flags for the feature.
Description of your changes
This change consumes MR metric changes from crossplane-runtime and configures metrics.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Deployed the custom version to a cluster and get metrics