Set default external name config as IdentifierFromProvider and a common referencer for project_id

crossplane-contrib / provider-mongodbatlas

MongoDB Atlas Provider based on Terrajet

Apache License 2.0

14 stars 11 forks source link

Set default external name config as IdentifierFromProvider and a common referencer for project_id #2

Closed turkenh closed 2 years ago

turkenh commented 2 years ago

Description of your changes

This PR:

Configures default external name config as IdentifierFromProvider.
Configures a common reference for project_id field that applies to all resources.
Some refactoring for resource defaulting

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

I didn't test but only run make generate.

I quickly skimmed through the resources in the Terraform provider and it looks like IdentifierFromProvider would better fit and bring the resources in a working state.

bitgandtter commented 2 years ago

Can we please add the same config for users? I'm having the same issue. This message is just to replicate what I mention over slack. Also I'm pretty sure that will be a recurrent issue with other resources

turkenh commented 2 years ago

Can we please add the same config for users? I'm having the same issue. This message is just to replicate what I mention over slack. Also, I'm pretty sure that will be a recurrent issue with other resources

Just pushed a change that configures all resources for, which would include user resource

External name as identifierFromProvider
Adds referencer for project_id field

bitgandtter commented 2 years ago

Any eta i really need this one please

bitgandtter commented 2 years ago

@ulucinar can this be merged please im blocked and I really want to use this provider. thanks so much in advance

turkenh commented 2 years ago

@ulucinar can this be merged please im blocked and I really want to use this provider. thanks so much in advance

@bitgandtter just noticed that there are some comments that need to be resolved, sorry for that. I'll work on them and try to get this merged ASAP.

abdelazizhd commented 2 years ago

Hi, we are waiting for this merge, any expected date or is there any other problem? Thanks

ulucinar commented 2 years ago

Thanks @turkenh, I will cut the v0.2.0 release tonight!

ulucinar commented 2 years ago

@abdelazizhd & @bitgandtter, you can give crossplane/provider-jet-mongodbatlas:v0.2.0 consuming this PR a try! Thank you all!

bitgandtter commented 2 years ago

@ulucinar got this after trying


observe failed: cannot run refresh: readObjectStart: expect { or n, but
        found S, error found in #1 byte of ...|Stack trace|..., bigger context
        ...|Stack trace from the terraform-provider-mongodbatla|...: refresh
        failed
``