search

crossplane-contrib / provider-mongodbatlas

MongoDB Atlas Provider based on Terrajet
Apache License 2.0
15 stars 11 forks source link

Fix IPAccessList resource configuration #3

Closed ulucinar closed 2 years ago

ulucinar commented 2 years ago

Description of your changes

Fixes IPAccessList resource and adds an example manifest for it.

I have:

How has this code been tested

Manually tested using the example manifest provided.

bitgandtter commented 2 years ago

can we please merge this one? I really need to use it @ulucinar

ulucinar commented 2 years ago

Hi folks, I checked whether we should make the databaseName of User a reference to Cluster as my interpretation is that you can refer to an existing cluster's name in that parameter but then, why not make it a reference to an AdvancedCluster? Currently, we have no support for generic cross-resource references, thus I chose not to implement cross-resource referencing for the field. Nevertheless, we can evolve the API at a later stage.

@bitgandtter, is my interpretation correct? Can it be a reference to a Cluster or to an AdvancedCluster?

github-actions[bot] commented 2 years ago

Successfully created backport PR #5 for release-0.2.