crossplane-contrib / provider-mongodbatlas

MongoDB Atlas Provider based on Terrajet
Apache License 2.0
15 stars 11 forks source link

Normalize Project API: remove `name` attribute #9

Closed ulucinar closed 2 years ago

ulucinar commented 2 years ago

Description of your changes

This PR proposes a change to remove the name attribute from the Project managed resource.

I have:

How has this code been tested

Tested provisioning a new Atlas project and importing an existing Project using the following manifests:

apiVersion: mongodbatlas.jet.crossplane.io/v1alpha1
kind: Project
metadata:
  name: example-project
spec:
  forProvider:
    orgId: "<mongodb atlas organization ID>"
  providerConfigRef:
    name: default

---

apiVersion: mongodbatlas.jet.crossplane.io/v1alpha1
kind: Project
metadata:
  name: example-project
  annotations:
    crossplane.io/external-name: <Project name>:<Project ID>
spec:
  forProvider:
    orgId: "<mongodb atlas organization ID>"
  providerConfigRef:
    name: default
Piotr1215 commented 2 years ago

Thank you @ulucinar, I tested CRUD operations on the project object and all works as expected :+1: