fix: ensure we always have an ID

[fernandezcuesta]

Description of your changes

id field in tfstate must be either filled in or omitted. This PR attempts to fix it by setting an intermediate value (PENDING) not to fall into the raised bug.

Fixes #66

I have:

• [x] Read and followed Crossplane's contribution process.
• [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Locally with valid credentials.

[fernandezcuesta]

Not sure if it is possible to omit the id from the tfstate by instructing upjet, but when we get the following we hit the bug as per #66:

The solution is either omit the "id" attribute or put any value on it (current workaround)

{
  "version": 4,
  "terraform_version": "1.5.5",
  "serial": 1,
  "lineage": "8a917ef2-2690-4360-9d29-0bf2a4dfe8b7",
  "outputs": null,
  "resources": [
    {
      "mode": "managed",
      "type": "pagerduty_team",
      "name": "test-team",
      "provider": "provider[\"registry.terraform.io/PagerDuty/pagerduty\"]",
      "instances": [
        {
          "schema_version": 0,
          "attributes": {
            "description": "Test team",
            "id": "",   <------------------- THIS SEEMS TO BE THE OFFENDER
            "name": "Test Team"
          }
        }
      ]
    }
  ]
}

[fernandezcuesta]

Looks to me like an error in the upstream terraform provider, which doesn't like having an empty id. Didn't find the way to instruct upjet not to set it in the tfstate

[fnicolelli-ls]

Hello team, i've tested this locally and it is working, i can deploy pagerduty Teams without any issues.

[fernandezcuesta]

@haarchri regarding the "fix" here, what I did so far:

• Check upstream tf provider, but its model seems OK. Whenever the id field is present but empty, it fails as stated here
• Check if we can omit the id field in the tfstate, but couldn't find how to instruct upjet to do so
• Set a fake id during the plan phase, which is basically ignored but fixes the wrong behaviour.
• Bump provider version and get rid of the restrictions on the discovered resources, add new resource (Jira integration)
• Fix the IDs of some resources available as of 0.10.0, which were not correct (not as simple as the ID field)
• Fix some missing selectors for those new resources
• Update examples from examples-generated
• Bump dependencies

Do you know if there's any way to omit the id field in tfstate? If not, I guess the solution here