crossplane-contrib / provider-sql

An SQL provider for @crossplane
https://crossplane.io
Apache License 2.0
104 stars 59 forks source link

feat(hana): add support for hana #151

Closed adriantankodev closed 1 year ago

adriantankodev commented 1 year ago

Description of your changes

My colleague @mirzakopic and I added support for the SAP HANA database. Following resources are available:

This of course allows other resources to be added later on. We have also added only the basic resource parameters for now, but it is extendable.

I have:

How has this code been tested

In order to increase code isolation, we decided to separate controller and client logic. Therefore tests for both are also separated.

Duologic commented 1 year ago

My initial feeling is that this would fit better in separate provider (perhaps one dedicated and/or owned by SAP?), WDYT?

adriantankodev commented 1 year ago

We have decided to create a separate provider as per your suggestion, so that it can be maintained directly by SAP. Thank you for the recommendation, I will go ahead and close the PR.