[Bug]: `ProviderConfig` uses `snake_case` fields - Githubissues

crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.

https://marketplace.upbound.io/providers/upbound/provider-aws

Apache License 2.0

138 stars 117 forks source link

[Bug]: `ProviderConfig` uses `snake_case` fields #1174

Open negz opened 4 months ago

negz commented 4 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Affected Resource(s)

aws.upbound.io/v1beta1 - ProviderConfig

Resource MRs required to reproduce the bug

N/A

Steps to Reproduce

Look at https://github.com/upbound/provider-aws/blob/v1.1.0/apis/v1beta1/types.go#L27

What happened?

Kubernetes API fields should be camelCase. This provider's ProviderConfig has a mix of camelCase and snake_case fields. For example:

spec.skip_credentials_validation
spec.skip_region_validation

etc

Relevant Error Output Snippet

No response

Crossplane Version

N/A

Provider Version

v1.1.0

Kubernetes Version

No response

Kubernetes Distribution

No response

Additional Info

No response

negz commented 4 months ago

I just learned there's a linter that can catch this. It's supported by golangci-lint: https://github.com/ldez/tagliatelle