crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
143 stars 120 forks source link

skip cluster_revision_number for redshift cluster #1191

Closed cci-nithin closed 1 month ago

cci-nithin commented 7 months ago

Is there an existing issue for this?

Affected Resource(s)

apiVersion: redshift.aws.upbound.io/v1beta1

kind: Cluster

Resource MRs required to reproduce the bug

No response

Steps to Reproduce

Diff after deploying redshift cluster.

What happened?

After creating redshift cluster using argocd, there is a Diff detected with cluster_revision_number missmatch.

2024-03-05T11:21:32Z DEBUG provider-aws Diff detected {"uid": "1234-be18-4943-b73c-ff155db8bc19", "name": "xyz", "gvk": "redshift.aws.upbound.io/v1beta1, Kind=Cluster", "instanceDiff": "terraform.InstanceDiff{mu:sync.Mutex{state:0, sema:0x0}, Attributes:map[string]terraform.ResourceAttrDiff{\"cluster_revision_number\":*terraform.ResourceAttrDiff{Old:\"63269\", New:\"57798\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}}, Destroy:false, DestroyDeposed:false, DestroyTainted:false, RawConfig:cty.NilVal, RawState:cty.NilVal, RawPlan:cty.NilVal, Meta:map[string]interface {}(nil)}"} 2024-03-05T11:21:32Z DEBUG provider-aws Successfully requested update of external resource {"controller": "managed/redshift.aws.upbound.io/v1beta1, kind=cluster", "request": {"name":"xyz"}, "uid": "2f67-be18-4943-b73c-ff155db8bc19", "version": "680924495", "external-name": "xyz", "requeue-after": "2024-03-05T11:31:53Z"}

conditions:

Relevant Error Output Snippet

No response

Crossplane Version

1.12.3-up.1

Provider Version

v1.1.0

Kubernetes Version

1.26

Kubernetes Distribution

EKS

Additional Info

No response

turkenf commented 4 months ago

Hi @cci-nithin,

Thank you for raising this issue, can you please try with the provider version 1.4.0 and if the problem reoccurs can you provide us the MRs you used?

github-actions[bot] commented 1 month ago

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

github-actions[bot] commented 1 month ago

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!

cci-nithin commented 1 month ago

@turkenf Its still the same even after the version upgrade.