search

crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
143 stars 120 forks source link

Sagemaker User Profile - Add Execution Role Selector #1193

Closed jasondroz closed 1 month ago

jasondroz commented 7 months ago

What problem are you facing?

For provider-aws-sagemaker the UserProfile only allows a statically set IAM execution role under spec.forProvider.userSettings

How could Official AWS Provider help solve your problem?

Add the selector feature like spec.forProvider.userSettings.executionRoleSelector to allow matchControllerRef and matchLabels to be used.

turkenf commented 5 months ago

Hi @jasondroz, thank you for bringing up this.

If you want to contribute we would appreciate it. Here is a guide about adding new ref and selector, if you have any questions feel free to ask.

And here is a current example, it is safer to use TerraformName instead of Type.

github-actions[bot] commented 1 month ago

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

github-actions[bot] commented 1 month ago

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!