crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
143 stars 120 forks source link

Update tf resource to aws sdk group overrides #1200

Open mbbush opened 7 months ago

mbbush commented 7 months ago

Description of your changes

I wrote a pair of scripts to

  1. Extract two lists of all the framework and sdk resources from the source code of terraform-provider-aws (shell/sed)
  2. Use the generated lists to build the GroupMap (python)

My motivation was while working on support for some new MSK resources, they ended up in api group msk instead of kakfa like the other msk resources, because they weren't on the GroupMap list.

While working on getting the code to fully generate the GroupMap, I discovered what looked like several mistakes in the behavior of the previous GroupMap. I added conditionals to preserve the existing behavior, because doing otherwise would have resulted in changing the kind or api group of the affected resources.

I have:

How has this code been tested

It produces zero diff to the generated code.