Closed erhancagirici closed 6 months ago
The issue with the publish-artifacts
job is a known one with the recent SSO changes. cc. @turkenf
The publish-artifacts
job is expected to fail due to the recent Upbound SSO changes. We will need to fix the credentials related to that job.
Description of your changes
refactors AWS client configuration logic with a single path.
Previously, the AWS config was following various paths due to:
eks.clusterAuth
resource has a manual controller implementation, since it is not terraform-based To handle these paths, a native AWS configuration was being constructed along with the terraform configuration attributes. These were causing in a non-unified configuration path, and duplicated AWS STS API calls due to configuration being processed by the native method and Terraform provider configure for no-fork.Since the TF CLI is removed all relevant configuration paths can be removed to simplify.
This PR:
As a result this leads to 50% reduction in STS calls made per reconcile. Further improvement to STS calls will follow with a cache implementation.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Tested manually with following ProviderConfig specifications: