crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
143 stars 120 forks source link

Unify TF AWS provider configuration logic #1204

Closed erhancagirici closed 6 months ago

erhancagirici commented 6 months ago

Description of your changes

refactors AWS client configuration logic with a single path.

Previously, the AWS config was following various paths due to:

Since the TF CLI is removed all relevant configuration paths can be removed to simplify.

This PR:

As a result this leads to 50% reduction in STS calls made per reconcile. Further improvement to STS calls will follow with a cache implementation.

I have:

How has this code been tested

Tested manually with following ProviderConfig specifications:

ulucinar commented 6 months ago

The issue with the publish-artifacts job is a known one with the recent SSO changes. cc. @turkenf

ulucinar commented 6 months ago

The publish-artifacts job is expected to fail due to the recent Upbound SSO changes. We will need to fix the credentials related to that job.