search

crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
143 stars 120 forks source link

[DO NOT MERGE] Test PR #1210

Closed ulucinar closed 6 months ago

ulucinar commented 6 months ago

Description of your changes

Fixes #

I have:

How has this code been tested

ulucinar commented 6 months ago

/test-examples="examples/eks/v1beta1/cluster.yaml"

ulucinar commented 6 months ago

/test-examples="examples/eks/v1beta1/cluster.yaml"

ulucinar commented 6 months ago

We've observed some instability with the linter in this PR: Our previous observation was we could run the second (full linting) phase with the maximum concurrency but the second phase has failed two times in the runs for this PR. We have also observed successful runs with the current parameters. But as a precaution, I currently believe it's a good idea to also limit its concurrency (as we've already done for the initial cache construction phase) and to run the disk cleanup job to allow for more virtual memory space. The latest successful run of the linter in this PR is with a concurrency of 3. We've also verified the linter can actually point to issues in this run:

image

We've also a recorded successful run for uptest for the examples/eks/v1beta1/cluster.yaml example manifest here.