crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
143 stars 120 forks source link

Add region parameter back to TF setup.Configuration #1221

Closed erhancagirici closed 6 months ago

erhancagirici commented 6 months ago

Description of your changes

Fixes #1220

1204 removed obsolete TF-CLI related configuration codepath and switched to native TF SDK configuration.

As a result of native SDK configuration, terraform.Setup.Configuration was no longer needed to configure TF AWS client and we cease

However, several external name configurations which use external name templates, still rely on terraform.Setup.Configuration map to obtain region value.

The change adds the region parameter back to terraform.Setup.Configuration.

I have:

How has this code been tested

With uptest, create resources that uses .setup.configuration in their external name configs

erhancagirici commented 6 months ago

/test-examples="examples/sns/v1beta1/topic.yaml"

mbbush commented 6 months ago

/test-examples="examples/kinesis/v1beta1/stream.yaml"

github-actions[bot] commented 6 months ago

Successfully created backport PR #1222 for release-1.2.