Closed ulucinar closed 3 months ago
The provider cache manager currently uses ProviderConfig.ResourceVersion when computing the cache keys. This PR changes it to ProviderConfig.Generation so that only ProviderConfig's spec updates will invalidate cache entries.
ProviderConfig.ResourceVersion
ProviderConfig.Generation
spec
I have:
make reviewable
backport release-x.y
Validated the PR using the package index.docker.io/ulucinar/provider-aws-iam:v1.3.0-8dbbc58fbd82da76ef5f8f50c34aa75494964bbd and by modifying the spec of the ProviderConfig. Also via uptest here: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8470828375
index.docker.io/ulucinar/provider-aws-iam:v1.3.0-8dbbc58fbd82da76ef5f8f50c34aa75494964bbd
ProviderConfig
/test-examples="examples/rds/v1beta1/clusterroleassociation.yaml"
Description of your changes
The provider cache manager currently uses
ProviderConfig.ResourceVersion
when computing the cache keys. This PR changes it toProviderConfig.Generation
so that only ProviderConfig'sspec
updates will invalidate cache entries.I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Validated the PR using the package
index.docker.io/ulucinar/provider-aws-iam:v1.3.0-8dbbc58fbd82da76ef5f8f50c34aa75494964bbd
and by modifying thespec
of theProviderConfig
. Also via uptest here: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8470828375