crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
137 stars 113 forks source link

Use Generation instead of ResourceVersion when computing the cache key #1244

Closed ulucinar closed 3 months ago

ulucinar commented 3 months ago

Description of your changes

The provider cache manager currently uses ProviderConfig.ResourceVersion when computing the cache keys. This PR changes it to ProviderConfig.Generation so that only ProviderConfig's spec updates will invalidate cache entries.

I have:

How has this code been tested

Validated the PR using the package index.docker.io/ulucinar/provider-aws-iam:v1.3.0-8dbbc58fbd82da76ef5f8f50c34aa75494964bbd and by modifying the spec of the ProviderConfig. Also via uptest here: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8470828375

turkenf commented 3 months ago

/test-examples="examples/rds/v1beta1/clusterroleassociation.yaml"