Closed erhancagirici closed 3 months ago
Is it possible to add a test to catch a regression here in the future? Is ClusterAuth already uptestable and we should consider it a critical component that should always be tested before a release?
Is it possible to add a test to catch a regression here in the future? Is ClusterAuth already uptestable and we should consider it a critical component that should always be tested before a release?
ClusterAuth is already uptestable, and included in the examples/v1beta1/cluster.yaml
. The MR actually gets created, switches to ready & synced state, and the connection details are published. In order to catch the regression here, the resulting kubeconfig in the connection details should be consumed.
We might consider utilizing https://github.com/upbound/configuration-aws-eks, some test MRs utilizing provider-kubernetes or some post-test script utilizing kubectl
. cc @ulucinar @sergenyalcin
Hi @erhancagirici,
We may consider utilizing an uptest post-assert-hook
for ClusterAuth.eks
in which we run a script that:
kubectl
command against that kubeconfigCould you please also trigger an uptest on ClusterAuth.eks
with these modifications? We may also consider adding the example manifest examples/eks/v1beta1/clusterauth.yaml
.
/test-examples="examples/eks/v1beta1/clusterauth.yaml"
/test-examples="examples/eks/v1beta1/clusterauth.yaml"
/test-examples="examples/eks/v1beta1/clusterauth.yaml"
Successfully created backport PR #1257 for release-1.3
.
It looks like this was probably caused by https://github.com/aws/aws-sdk-go-v2/pull/2438. I see a bunch of other projects citing that PR as an issue too. I don't understand why yet.
Description of your changes
Fixes #1248 Recent patch version bumps at the following
aws-sdk-go-v2
modules seems to break the request signature of the token for the generated kubeconfig forClusterAuth
resource.This change reverts the version bumps and pins the versions. Adds a separate standalone example manifest for
ClusterAuth
resource and added an Uptest post-assert hook for testing the resulting kubeconfig, by executing simple kubectl commands to ensure the cluster authentication.I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
ClusterAuth
MR example, that fails on 1.3.0