search

crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
137 stars 113 forks source link

re-order columns for handwritten ClusterAuth.eks #1276

Closed mbbush closed 4 weeks ago

mbbush commented 2 months ago

Description of your changes

There was a recent change in upjet that swapped the order of the Ready and Synced columns in the generated managed resource CRDs. That's already been merged and released in provider-upjet-aws. However, we forgot about ClusterAuth.eks, which is the only (I think?) CRD that's not generated by upjet.

The result is that currently when listing managed resources, for all MR kinds other than ClusterAuth, Synced appears before Ready, but for ClusterAuth, Ready appears before synced.

This PR fixes that.

I have:

How has this code been tested

Using uptest on this PR and manually:

NAME                                  SYNCED   READY   EXTERNAL-NAME   AGE
clusterauth.eks.aws.upbound.io/auth   True     True    auth            10m
mbbush commented 2 months ago

/test-examples="examples/eks/v1beta1/clusterauth.yaml"

turkenf commented 4 weeks ago

/test-examples="examples/eks/v1beta1/clusterauth.yaml"

turkenf commented 4 weeks ago

Thank you @mbbush 🙌