crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
137 stars 112 forks source link

[Cluster.RDS] Add `ClusterParameterGroup` and `ParameterGroup` Selectors #1288

Closed ytsarev closed 2 months ago

ytsarev commented 2 months ago

Description of your changes

I have:

How has this code been tested

make e2e UPTEST_EXAMPLE_LIST=examples/rds/v1beta1/cluster.yaml
...
--- PASS: kuttl (155.21s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (154.42s)
PASS
22:37:06 [ OK ] running automated tests

Checked that parameter groups are properly selected in cluster spec

spec:
  deletionPolicy: Delete
  forProvider:
    allocatedStorage: 1
    autoGeneratePassword: true
    availabilityZones:
    - us-west-1b
    - us-west-1c
    backupRetentionPeriod: 1
    dbClusterParameterGroupName: example-ci-cluster
    dbClusterParameterGroupNameRef:
      name: example-ci-cluster
    dbClusterParameterGroupNameSelector:
      matchLabels:
        testing.upbound.io/example-name: example-ci-cluster
    dbInstanceParameterGroupName: example-parametergroup-ci-cluster-instance
    dbInstanceParameterGroupNameRef:
      name: example-parametergroup-ci-cluster-instance
    dbInstanceParameterGroupNameSelector:
      matchLabels:
        testing.upbound.io/example-name: example-ci-cluster-instance

Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8812738711

ytsarev commented 2 months ago

/test-examples="examples/rds/v1beta1/cluster.yaml"

jeanduplessis commented 2 months ago

/test-examples="examples/rds/v1beta1/cluster.yaml"