Add MQ User resource - Githubissues

crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.

https://marketplace.upbound.io/providers/upbound/provider-aws

Apache License 2.0

137 stars 112 forks source link

Add MQ User resource #1311

Closed mergenci closed 1 month ago

mergenci commented 1 month ago

Description of your changes

Add MQ User resource by consuming https://github.com/upbound/terraform-provider-aws/pull/236.

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Manually tested by applying the example manifest.

ulucinar commented 1 month ago

Let's wait for #1315 before we merge this...

ulucinar commented 1 month ago

To prevent the race between the new User.mq and Broker.mq controllers, we will need to consume https://github.com/crossplane/upjet/pull/406 & https://github.com/crossplane/upjet/pull/407 and do a late-initialization configuration.

ulucinar commented 1 month ago

Hi @mergenci, A local run of make lint on the head of this PR's feature branch has succeeded. No need to wait for the linter job if you'd like to continue merging...

mergenci commented 1 month ago

Thanks @ulucinar 🙏 This PR has been a wild ride in many ways 🙂