search

crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
137 stars 112 forks source link

Unpin the `aws-sdk-go-v2` dependency #1317

Closed ulucinar closed 1 month ago

ulucinar commented 1 month ago

What problem are you facing?

We've pinned the aws-sdk-go-v2 dependency to resolve an issue with a quick workaround. However, we will need to update this dependency at a point in time and we need to address the underlying issue by changing how we use the AWS Go SDK to fetch the EKS cluster credentials.

We need to verify the ClusterAuth.eks functionality before merging #1315.

This issue also demonstrates the extra maintenance burden on us when we implement resources using the AWS Go SDK.

How could Official AWS Provider help solve your problem?

Let's find out how we should now fetch the credentials using the AWS Go SDK and remove the pin.

ulucinar commented 1 month ago

I've done the following tests with #1315 and can confirm that the kubeconfigs prepared by the ClusterAuth.eks resource are still functional when we bump the aws-sdk-go-v2 dependency to v1.26.2. I've verified this using the following authentication configurations:

Looks like it's safe to continue with #1315.