crossplane-contrib / provider-upjet-aws

Official AWS Provider for Crossplane by Upbound.
https://marketplace.upbound.io/providers/upbound/provider-aws
Apache License 2.0
137 stars 112 forks source link

ElastiCache ReplicationGroup auth token generation and connection details #1322

Closed chlunde closed 4 weeks ago

chlunde commented 1 month ago

Description of your changes

Fixes #1102

I have:

How has this code been tested

Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9397299773

haarchri commented 1 month ago

@chlunde i am interested too in this PR - do you need help to finish ?

chlunde commented 1 month ago

Cool, I will try to fix it tonight, I will let you know if there's some issue I need help wit (except for review and approval) 😀

chlunde commented 1 month ago

@haarchri I pushed again now. I changed the example region to us-east-1 and added a VPC to get a complete example. The existing region has only two az-s per account so it's not good for examples.

I'm a bit confused as I don't remember getting an error about needing a VPC to use auth tokens the last time I tested, but now I do. This is why I added a VPC to the example.

chlunde commented 1 month ago
kind: Secret
apiVersion: v1
data:
  attribute.auth_token: VDN4S2dVaFNsVFllMVFScmpmUFNGYTB5aUl4
  port: NjM3OQ==
  primary_endpoint_address: ...==
  reader_endpoint_address: ...=
ulucinar commented 1 month ago

/test-examples="examples/elasticache/v1beta2/replicationgroup.yaml"

turkenf commented 4 weeks ago

Hi @chlunde, thank you for your effort in this PR.

The v1.6.0 release is planned for tomorrow, June 6, we want to include this PR in tomorrow's release. If you do not have time to address review comments, please let us know.

chlunde commented 4 weeks ago

@turkenf @ulucinar Thanks for the review! I think the two remaining comments apply to common.PasswordGenerator in general?

turkenf commented 4 weeks ago

/test-examples="examples/elasticache/v1beta2/replicationgroup.yaml"